zhangstar333 commented on code in PR #34857:
URL: https://github.com/apache/doris/pull/34857#discussion_r1599966919
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnBE.java:
##########
@@ -140,6 +141,15 @@ public static Expression
foldByBE(ExpressionMatchingContext<Expression> context)
if (root instanceof Alias) {
rootWithoutAlias = ((Alias) root).child();
}
+
+ // FIXME: remove this when we
+ if (rootWithoutAlias instanceof BoundFunction
Review Comment:
could abstract those to a function, eg: `skipGEOFunctions`(),
so could know it directly.
maybe could ref `skipSleepFunction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
