suxiaogang223 commented on code in PR #34743:
URL: https://github.com/apache/doris/pull/34743#discussion_r1600562372
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -1750,6 +1750,11 @@ Status OrcReader::get_next_block(Block* block, size_t*
read_rows, bool* eof) {
RETURN_IF_CATCH_EXCEPTION(Block::filter_block_internal(block,
columns_to_filter,
(*_delete_rows_filter_ptr)));
}
+ // TODO: Check compatibility of deletion vector and lazy reading
+ IColumn::Filter result_filter(block->rows(), 1);
+ _execute_filter_position_delete_rowids(result_filter);
Review Comment:
These changes also happened in https://github.com/apache/doris/pull/34814. I
will rebase when this pr merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
