github-actions[bot] commented on code in PR #34878:
URL: https://github.com/apache/doris/pull/34878#discussion_r1600867395
##########
be/src/vec/olap/block_reader.cpp:
##########
@@ -164,9 +164,9 @@ Status BlockReader::_init_collect_iter(const ReaderParams&
read_params) {
return Status::OK();
}
-void BlockReader::_init_agg_state(const ReaderParams& read_params) {
+Status BlockReader::_init_agg_state(const ReaderParams& read_params) {
Review Comment:
warning: method '_init_agg_state' can be made const
[readability-make-member-function-const]
```suggestion
Status BlockReader::_init_agg_state(const ReaderParams& read_params) const {
```
be/src/vec/olap/block_reader.h:74:
```diff
- Status _init_agg_state(const ReaderParams& read_params);
+ Status _init_agg_state(const ReaderParams& read_params) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
