XieJiann commented on code in PR #34480:
URL: https://github.com/apache/doris/pull/34480#discussion_r1601006067
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalPlan.java:
##########
@@ -70,19 +71,25 @@ default FunctionalDependencies computeFuncDeps() {
computeFd(fdBuilder);
ImmutableSet<FdItem> fdItems = computeFdItems();
fdBuilder.addFdItems(fdItems);
+
+ List<Set<Slot>> uniqueSlots = fdBuilder.getAllUnique();
+ Set<Slot> uniformSlots = fdBuilder.getAllUniform();
for (Slot slot : getOutput()) {
Set<Slot> o = ImmutableSet.of(slot);
// all slot dependents unique slot
- for (Set<Slot> uniqueSlot : fdBuilder.getAllUnique()) {
+ for (Set<Slot> uniqueSlot : uniqueSlots) {
fdBuilder.addDeps(uniqueSlot, o);
}
// uniform slot dependents all unique slot
Review Comment:
Yeah, you are right. I'll fix it in the next pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
