zhannngchen commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1601279443
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -290,6 +290,10 @@ Status Segment::_load_pk_bloom_filter() {
return _load_pk_bf_once.call([this] {
RETURN_IF_ERROR(_pk_index_reader->parse_bf(_file_reader,
*_pk_index_meta));
_meta_mem_usage += _pk_index_reader->get_bf_memory_size();
+ SegmentCache::CacheKey cache_key(_rowset_id, _segment_id);
Review Comment:
Sometimes, we might call `_load_pk_bloom_filter()` on `Segment` objects that
not in cache. Not all Segment object should in SegmentCache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
