zhiqiang-hhhh commented on code in PR #34689:
URL: https://github.com/apache/doris/pull/34689#discussion_r1602520447
##########
be/src/vec/data_types/data_type_date_time.cpp:
##########
@@ -56,6 +56,14 @@ std::string DataTypeDateTime::to_string(const IColumn&
column, size_t row_num) c
return buf;
}
+std::string DataTypeDateTime::to_string(Int64 int_val) const {
Review Comment:
since `to string` of decimal can not be static
##########
be/src/vec/data_types/data_type_date_time.h:
##########
@@ -84,6 +84,7 @@ class DataTypeDateTime final : public
DataTypeNumberBase<Int64> {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
+ std::string to_string(Int64 value) const;
Review Comment:
since `to string` of decimal can not be static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
