w41ter commented on code in PR #34873:
URL: https://github.com/apache/doris/pull/34873#discussion_r1606197209
##########
be/src/olap/wal/wal_reader.cpp:
##########
@@ -50,11 +50,8 @@ Status WalReader::init() {
}
Status WalReader::finalize() {
- if (file_reader != nullptr) {
- auto st = file_reader->close();
- if (!st.ok()) {
- LOG(WARNING) << "fail to close wal " << _file_name << " st= " <<
st.to_string();
- }
+ if (file_reader) {
+ return file_reader->close();
Review Comment:
It should have been returned but was left out. This change is LGTM.
##########
be/src/vec/exec/format/wal/wal_reader.cpp:
##########
@@ -30,12 +30,6 @@ WalReader::WalReader(RuntimeState* state) : _state(state) {
_wal_id = state->wal_id();
}
-WalReader::~WalReader() {
Review Comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
