zhangbutao commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1606578056
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java:
##########
@@ -169,6 +170,7 @@ public class HMSExternalTable extends ExternalTable
implements MTMVRelatedTableI
// for hudi incremental read
private TableScanParams scanParams = null;
private IncrementalRelation incrementalRelation = null;
+ private TableSnapshot tableSnapshot = null;
Review Comment:
Thanks for you suggesstion!
I refine this PR in
https://github.com/apache/doris/pull/34681/commits/21081393f5ddf734cea06c52c7ed73a7079ec7e2.
Now we can support all types of iceberg tables, and i set the snapshot in
IcebergScanNode through method `PhysicalPlanTranslator::visitPhysicalFileScan `.
Please help to check if this change is good for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
