englefly commented on code in PR #34853:
URL: https://github.com/apache/doris/pull/34853#discussion_r1609152816
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalHashAggregate.java:
##########
@@ -60,6 +61,9 @@ public class PhysicalHashAggregate<CHILD_TYPE extends Plan>
extends PhysicalUnar
private final RequireProperties requireProperties;
+ // only used in post processor
+ private TopNOptInfo topn = null;
Review Comment:
post 阶段使用的变量就不用immutable吧，否则会增加很多无用的with函数，而且还容易会破坏其它processor的结果
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
