xy720 commented on code in PR #35278:
URL: https://github.com/apache/doris/pull/35278#discussion_r1611235059
##########
be/src/http/action/compaction_action.cpp:
##########
@@ -178,10 +195,8 @@ Status
CompactionAction::_handle_run_compaction(HttpRequest* req, std::string* j
Status CompactionAction::_handle_run_status_compaction(HttpRequest* req,
std::string* json_result) {
uint64_t tablet_id = 0;
- uint64_t table_id = 0;
-
- // check req_tablet_id is not empty
- RETURN_NOT_OK_STATUS_WITH_WARN(_check_param(req, &tablet_id, &table_id),
"check param failed");
+ RETURN_NOT_OK_STATUS_WITH_WARN(_check_param(req, &tablet_id,
TABLET_ID_KEY),
Review Comment:
please add some comments here.
##########
be/src/http/action/compaction_action.cpp:
##########
@@ -61,7 +61,7 @@ CompactionAction::CompactionAction(CompactionActionType
ctype, ExecEnv* exec_env
TPrivilegeType::type ptype)
: HttpHandlerWithAuth(exec_env, hier, ptype), _engine(engine),
_type(ctype) {}
-/// check param and fetch tablet_id from req
+/// check param and fetch tablet_id & table_id from req
Review Comment:
You should modify the comment in cloud compaction action too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
