This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 14c209c [refactor] remove useless if statement in segment_writer.cpp
(#7864)
14c209c is described below
commit 14c209c7cf40f3b823bc5be4a417a155ac689c62
Author: dataroaring <[email protected]>
AuthorDate: Mon Jan 31 22:12:54 2022 +0800
[refactor] remove useless if statement in segment_writer.cpp (#7864)
---
be/src/olap/rowset/segment_v2/segment_writer.cpp | 6 ++----
gensrc/proto/segment_v2.proto | 2 +-
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/be/src/olap/rowset/segment_v2/segment_writer.cpp
b/be/src/olap/rowset/segment_v2/segment_writer.cpp
index 6ac3538..adbfef9 100644
--- a/be/src/olap/rowset/segment_v2/segment_writer.cpp
+++ b/be/src/olap/rowset/segment_v2/segment_writer.cpp
@@ -57,10 +57,8 @@ void SegmentWriter::init_column_meta(ColumnMetaPB* meta,
uint32_t* column_id,
meta->set_encoding(DEFAULT_ENCODING);
meta->set_compression(LZ4F);
meta->set_is_nullable(column.is_nullable());
- if (column.get_subtype_count() > 0) {
- for (uint32_t i = 0; i < column.get_subtype_count(); ++i) {
- init_column_meta(meta->add_children_columns(), column_id,
column.get_sub_column(i));
- }
+ for (uint32_t i = 0; i < column.get_subtype_count(); ++i) {
+ init_column_meta(meta->add_children_columns(), column_id,
column.get_sub_column(i));
}
}
diff --git a/gensrc/proto/segment_v2.proto b/gensrc/proto/segment_v2.proto
index cc767f8..3f41977 100644
--- a/gensrc/proto/segment_v2.proto
+++ b/gensrc/proto/segment_v2.proto
@@ -166,7 +166,7 @@ message SegmentFooterPB {
optional uint32 version = 1 [default = 1]; // file version
repeated ColumnMetaPB columns = 2; // tablet schema
optional uint32 num_rows = 3; // number of values
- optional uint64 index_footprint = 4; // total idnex footprint of all
columns
+ optional uint64 index_footprint = 4; // total index footprint of all
columns
optional uint64 data_footprint = 5; // total data footprint of all columns
optional uint64 raw_data_footprint = 6; // raw data footprint
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
