yiguolei commented on code in PR #35321:
URL: https://github.com/apache/doris/pull/35321#discussion_r1612988244
##########
be/src/service/internal_service.cpp:
##########
@@ -592,19 +592,12 @@ void
PInternalService::cancel_plan_fragment(google::protobuf::RpcController* /*c
actual_cancel_status = Status::InternalError("unknown error");
}
- if (request->has_fragment_id()) {
- TUniqueId query_id;
- query_id.__set_hi(request->query_id().hi());
- query_id.__set_lo(request->query_id().lo());
- LOG(INFO) << fmt::format("Cancel query {}, reason: {}",
print_id(query_id),
- actual_cancel_status.to_string());
- _exec_env->fragment_mgr()->cancel_fragment(query_id,
request->fragment_id(),
- actual_cancel_status);
- } else {
- LOG(INFO) << fmt::format("Cancel instance {}, reason: {}",
print_id(tid),
- actual_cancel_status.to_string());
- _exec_env->fragment_mgr()->cancel_instance(tid,
actual_cancel_status);
- }
+ TUniqueId query_id;
Review Comment:
这么改不对，
需要兼容当BE 升级了，FE 没升级的情况。此时FE 还是发送的fragment id 或者instance id。
所以老的代码不能删。
加上 if (reqeust.has_query_id) 这个样子
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
