xzj7019 commented on code in PR #34853:
URL: https://github.com/apache/doris/pull/34853#discussion_r1615835506
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1195,6 +1195,9 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag)
{
@VariableMgr.VarAttr(name = REWRITE_OR_TO_IN_PREDICATE_THRESHOLD, fuzzy =
true)
private int rewriteOrToInPredicateThreshold = 2;
+ @VariableMgr.VarAttr(name = "push_topn_to_agg", fuzzy = false, needForward
= true)
+ public boolean pushTopnToAgg = true;
Review Comment:
it will be bad case when the input stream data is ordered by desc and the
generated filter can't filter any data any all and introduce the additional
cost compared with original execution.
so can we do a data measurement for the worst case and let's know when will
happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
