zclllyybb commented on code in PR #35370:
URL: https://github.com/apache/doris/pull/35370#discussion_r1616183888
##########
be/src/olap/hll.h:
##########
@@ -231,12 +231,9 @@ class HyperLogLog {
int64_t estimate_cardinality() const;
- static std::string empty() {
+ static HyperLogLog empty() {
static HyperLogLog hll;
Review Comment:
use RVO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
