mymeiyi commented on code in PR #32523:
URL: https://github.com/apache/doris/pull/32523#discussion_r1616493161
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -591,16 +588,9 @@ public void execute(TUniqueId queryId) throws Exception {
LOG.warn("Analyze failed. {}",
context.getQueryIdentifier(), e);
throw ((NereidsException) e).getException();
}
- // FIXME: Force fallback for group commit because nereids
does not support it
- boolean isInsertCommand = parsedStmt != null
- && parsedStmt instanceof LogicalPlanAdapter
- && ((LogicalPlanAdapter)
parsedStmt).getLogicalPlan() instanceof InsertIntoTableCommand;
- boolean isGroupCommit =
(Config.wait_internal_group_commit_finish
- ||
context.sessionVariable.isEnableInsertGroupCommit()) && isInsertCommand;
if (e instanceof NereidsException
&& !(((NereidsException) e).getException()
instanceof MustFallbackException)
- &&
!context.getSessionVariable().enableFallbackToOriginalPlanner
- && !isGroupCommit) {
+ &&
!context.getSessionVariable().enableFallbackToOriginalPlanner) {
Review Comment:
`generateHttpStreamPlan` method also contain this logic, should remove it too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
