gavinchou commented on code in PR #35494:
URL: https://github.com/apache/doris/pull/35494#discussion_r1616621943
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/OlapInsertExecutor.java:
##########
@@ -147,13 +151,15 @@ public void finalizeSink(PlanFragment fragment, DataSink
sink, PhysicalSink phys
} catch (Exception e) {
throw new AnalysisException(e.getMessage(), e);
}
- TransactionState state =
Env.getCurrentGlobalTransactionMgr().getTransactionState(database.getId(),
txnId);
- if (state == null) {
- throw new AnalysisException("txn does not exist: " + txnId);
- }
- addTableIndexes(state);
- if (physicalOlapTableSink.isPartialUpdate()) {
- state.setSchemaForPartialUpdate((OlapTable) table);
+ if (!isGroupCommitHttpStream()) {
Review Comment:
Try the following pattern to reduce indention and possible conflict
```suggestion
if (isGroupCommitHttpStream()) {
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
