platoneko commented on code in PR #35473:
URL: https://github.com/apache/doris/pull/35473#discussion_r1616642679
##########
be/src/olap/tablet.cpp:
##########
@@ -1857,20 +1833,19 @@ void
Tablet::_init_context_common_fields(RowsetWriterContext& context) {
if (context.rowset_type == ALPHA_ROWSET) {
context.rowset_type = _engine.default_rowset_type();
}
- if (context.fs != nullptr && context.fs->type() !=
io::FileSystemType::LOCAL) {
- context.rowset_dir = remote_tablet_path(tablet_id());
- } else {
- context.rowset_dir = tablet_path();
+
+ if (context.is_local_rowset()) {
+ context.tablet_path = _tablet_path;
}
Review Comment:
Tablet 没有绑定到某个 StorageResource，无法计算出来 `tablet_path`
##########
be/src/olap/tablet.cpp:
##########
@@ -1857,20 +1833,19 @@ void
Tablet::_init_context_common_fields(RowsetWriterContext& context) {
if (context.rowset_type == ALPHA_ROWSET) {
context.rowset_type = _engine.default_rowset_type();
}
- if (context.fs != nullptr && context.fs->type() !=
io::FileSystemType::LOCAL) {
- context.rowset_dir = remote_tablet_path(tablet_id());
- } else {
- context.rowset_dir = tablet_path();
+
+ if (context.is_local_rowset()) {
+ context.tablet_path = _tablet_path;
}
Review Comment:
CloudTablet 没有绑定到某个 StorageResource，无法计算出来 `tablet_path`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
