Mryange commented on code in PR #35239:
URL: https://github.com/apache/doris/pull/35239#discussion_r1616982602
##########
be/src/vec/functions/function_ip.h:
##########
@@ -137,13 +139,7 @@ static inline bool try_parse_ipv4(const char* pos, Int64&
result_value) {
template <IPConvertExceptionMode exception_mode, typename ToColumn>
ColumnPtr convert_to_ipv4(ColumnPtr column, const PaddedPODArray<UInt8>*
null_map = nullptr) {
- const ColumnString* column_string =
check_and_get_column<ColumnString>(column.get());
-
- if (!column_string) {
- throw Exception(ErrorCode::INVALID_ARGUMENT,
- "Illegal column {} of argument of function {},
expected String",
- column->get_name());
- }
+ const auto* column_string =
check_and_get_column<ColumnString>(column.get());
Review Comment:
If nullptr is not checked here, then may be using assert cast？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
