yangzhg commented on a change in pull request #8000:
URL: https://github.com/apache/incubator-doris/pull/8000#discussion_r804371796
##########
File path: be/src/exec/tablet_sink.cpp
##########
@@ -571,7 +577,7 @@ void IndexChannel::add_row(Tuple* tuple, int64_t tablet_id)
{
// if this node channel is already failed, this add_row will be skipped
auto st = channel->add_row(tuple, tablet_id);
if (!st.ok()) {
- mark_as_failed(channel, st.get_error_msg(), tablet_id);
+ mark_as_failed(channel.get(), st.get_error_msg(), tablet_id);
Review comment:
But I don't think it's a good practice to mix smart pointers and raw
pointers. When we use smart pointers, we already imply that object ownership is
managed by smart pointers instead of accessing raw pointers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
