HappenLee commented on a change in pull request #7972:
URL: https://github.com/apache/incubator-doris/pull/7972#discussion_r804380222
##########
File path: be/src/vec/exec/join/vhash_join_node.cpp
##########
@@ -711,45 +766,62 @@ Status HashJoinNode::get_next(RuntimeState* state, Block*
output_block, bool* eo
Status st;
if (_probe_index < _probe_block.rows()) {
- MutableBlock mutable_block = (output_block->mem_reuse() &&
!_have_other_join_conjunct) ?
- MutableBlock(output_block) :
- MutableBlock(VectorizedUtils::create_empty_columnswithtypename(
- !_have_other_join_conjunct ? row_desc() :
_row_desc_for_other_join_conjunt));
-
std::visit(
- [&](auto&& arg) {
+ [&](auto&& arg, auto have_other_join_conjunct,
+ auto is_left_semi_join, auto is_left_anti_join, auto
is_inner_join) {
Review comment:
why keep so many bool, maybe you should use std::variant<std::monostate,
Inner Join, Semi Join, Anti Join
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
