This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.1 by this push:
     new 3736d0af13a [Fix](hive-writer) Fix s3 file commiter not working. 
(#35502) (#35579)
3736d0af13a is described below

commit 3736d0af13acbb454197885cf66747f09e60630b
Author: Mingyu Chen <[email protected]>
AuthorDate: Wed May 29 12:14:42 2024 +0800

    [Fix](hive-writer) Fix s3 file commiter not working. (#35502) (#35579)
    
    bp #35502
    
    Co-authored-by: Qi Chen <[email protected]>
---
 be/src/vec/sink/writer/vhive_partition_writer.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/be/src/vec/sink/writer/vhive_partition_writer.cpp 
b/be/src/vec/sink/writer/vhive_partition_writer.cpp
index 189e0211e52..f05acece2e8 100644
--- a/be/src/vec/sink/writer/vhive_partition_writer.cpp
+++ b/be/src/vec/sink/writer/vhive_partition_writer.cpp
@@ -128,9 +128,6 @@ Status VHivePartitionWriter::open(RuntimeState* state, 
RuntimeProfile* profile)
 }
 
 Status VHivePartitionWriter::close(const Status& status) {
-    if (status.ok()) {
-        
_state->hive_partition_updates().emplace_back(_build_partition_update());
-    }
     if (_file_format_transformer != nullptr) {
         Status st = _file_format_transformer->close();
         if (!st.ok()) {
@@ -145,6 +142,9 @@ Status VHivePartitionWriter::close(const Status& status) {
             LOG(WARNING) << fmt::format("Delete file {} failed, reason: {}", 
path, st.to_string());
         }
     }
+    if (status.ok()) {
+        
_state->hive_partition_updates().emplace_back(_build_partition_update());
+    }
     return Status::OK();
 }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to