github-actions[bot] commented on code in PR #35595:
URL: https://github.com/apache/doris/pull/35595#discussion_r1618380081
##########
be/src/pipeline/pipeline_tracing.h:
##########
@@ -47,12 +47,24 @@ struct ScheduleRecord {
}
};
+struct QueryID {
+ TUniqueId query_id;
+ bool operator<(const QueryID& query_id_) const {
+ return query_id.hi < query_id_.query_id.hi ||
+ (query_id.hi == query_id_.query_id.hi && query_id.lo <
query_id_.query_id.lo);
+ }
+ bool operator==(const QueryID& query_id_) const { return query_id ==
query_id_.query_id; }
+};
+
// all tracing datas of ONE specific query
using OneQueryTraces = moodycamel::ConcurrentQueue<ScheduleRecord>;
+using OneQueryTracesSPtr =
std::shared_ptr<moodycamel::ConcurrentQueue<ScheduleRecord>>;
+using QueryTracesMap = std::map<QueryID, OneQueryTracesSPtr>;
// belongs to exec_env, for all query, if enabled
class PipelineTracerContext {
public:
+ PipelineTracerContext() : _data(std::make_shared<QueryTracesMap>()) {}
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
PipelineTracerContext() : _data(std::make_shared<QueryTracesMap>()) =
default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
