ByteYue commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1622712118
##########
be/src/util/s3_util.cpp:
##########
@@ -156,9 +159,9 @@ S3ClientFactory& S3ClientFactory::instance() {
return ret;
}
-std::shared_ptr<Aws::S3::S3Client> S3ClientFactory::create(const S3ClientConf&
s3_conf) {
+std::shared_ptr<io::ObjStorageClient> S3ClientFactory::create(const
S3ClientConf& s3_conf) {
Review Comment:
I think it could be one future work, since change the class name might be
error-prone at developing time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
