This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 896415aa68e [Chore](materialized-view) enable create mv on mow table
(#35797)
896415aa68e is described below
commit 896415aa68eee2242ae3bb14c583eb0e4eae42c0
Author: Pxl <[email protected]>
AuthorDate: Mon Jun 3 18:38:01 2024 +0800
[Chore](materialized-view) enable create mv on mow table (#35797)
## Proposed changes
enable create mv on mow table
---
.../org/apache/doris/alter/MaterializedViewHandler.java | 3 ---
regression-test/data/mv_p0/test_mv_mow/test_mv_mow.out | 5 +++++
.../mow_invalid.groovy => test_mv_mow/test_mv_mow.groovy} | 15 +++++++++++----
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
b/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
index 703c5954544..635d0e63962 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
@@ -485,9 +485,6 @@ public class MaterializedViewHandler extends AlterHandler {
if (olapTable.hasMaterializedIndex(addMVClause.getMVName())) {
throw new DdlException("Materialized view[" +
addMVClause.getMVName() + "] already exists");
}
- if (olapTable.getEnableUniqueKeyMergeOnWrite()) {
- throw new DdlException("MergeOnWrite table can't create
materialized view.");
- }
if (olapTable.getRowStoreCol() != null) {
throw new DdlException("RowStore table can't create materialized
view.");
}
diff --git a/regression-test/data/mv_p0/test_mv_mow/test_mv_mow.out
b/regression-test/data/mv_p0/test_mv_mow/test_mv_mow.out
new file mode 100644
index 00000000000..8f75424779a
--- /dev/null
+++ b/regression-test/data/mv_p0/test_mv_mow/test_mv_mow.out
@@ -0,0 +1,5 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !select_mv --
+1 2
+1 3
+
diff --git a/regression-test/suites/mv_p0/test_mv_useless/mow_invalid.groovy
b/regression-test/suites/mv_p0/test_mv_mow/test_mv_mow.groovy
similarity index 74%
rename from regression-test/suites/mv_p0/test_mv_useless/mow_invalid.groovy
rename to regression-test/suites/mv_p0/test_mv_mow/test_mv_mow.groovy
index febdc259a74..dfe08f4dcd0 100644
--- a/regression-test/suites/mv_p0/test_mv_useless/mow_invalid.groovy
+++ b/regression-test/suites/mv_p0/test_mv_mow/test_mv_mow.groovy
@@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.
-suite ("mow_invalid") {
+suite ("test_mv_mow") {
sql """ drop table if exists u_table; """
sql """
@@ -32,9 +32,16 @@ suite ("mow_invalid") {
"enable_unique_key_merge_on_write" = "true"
);
"""
+ sql "insert into u_table select 1,1,1,1;"
+ sql "insert into u_table select 1,2,1,1;"
+ createMV("create materialized view k123p as select k1,k2+k3 from u_table;")
- test {
- sql "create materialized view k123p as select k1,k2+k3 from u_table;"
- exception "errCode = 2,"
+ sql "insert into u_table select 1,1,1,1;"
+ sql "insert into u_table select 1,2,1,1;"
+
+ explain {
+ sql("select k1,k2+k3 from u_table order by k1;")
+ contains "(k123p)"
}
+ qt_select_mv "select k1,k2+k3 from u_table order by k1;"
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
