github-actions[bot] commented on code in PR #35861:
URL: https://github.com/apache/doris/pull/35861#discussion_r1625625586
##########
be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:
##########
@@ -114,7 +115,7 @@ Status
SchemaRowsetsScanner::get_next_block(vectorized::Block* block, bool* eos)
Status SchemaRowsetsScanner::_fill_block_impl(vectorized::Block* block) {
Review Comment:
warning: function '_fill_block_impl' has cognitive complexity of 52
(threshold 50) [readability-function-cognitive-complexity]
```cpp
Status SchemaRowsetsScanner::_fill_block_impl(vectorized::Block* block) {
^
```
<details>
<summary>Additional context</summary>
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:124:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:127:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 0, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:127:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 0, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:133:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:140:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 1, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:140:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 1, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:145:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:150:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 2, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:150:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 2, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:155:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:160:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 3, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:160:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 3, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:165:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:170:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 4, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:170:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 4, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:175:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:180:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 5, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:180:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 5, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:185:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:190:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 6, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:190:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 6, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:195:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:200:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 7, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:200:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 7, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:205:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:210:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 8, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:210:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 8, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:215:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:220:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 9, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:220:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 9, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:225:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:231:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 10, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:231:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 10, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:236:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:243:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 11, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:243:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 11, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:248:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:253:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 12, datas));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/schema_scanner/schema_rowsets_scanner.cpp:253:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_dest_column_for_range(block, 12, datas));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
