yiguolei commented on code in PR #35841:
URL: https://github.com/apache/doris/pull/35841#discussion_r1626038867
##########
be/src/vec/common/uint128.h:
##########
@@ -152,31 +64,10 @@ struct UInt128HashCRC32 : public UInt128Hash {};
#endif
struct UInt128TrivialHash {
- size_t operator()(UInt128 x) const { return x.low; }
+ size_t operator()(UInt128 x) const { return x.items[0]; }
Review Comment:
I think we should use low and high, its better than iterms 0 or 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
