HappenLee commented on code in PR #35628:
URL: https://github.com/apache/doris/pull/35628#discussion_r1627417466
##########
be/src/olap/rowset/segment_v2/column_writer.cpp:
##########
@@ -88,267 +88,305 @@ class NullBitmapBuilder {
RleEncoder<bool> _rle_encoder;
};
+Status ColumnWriter::create_struct_writer(const ColumnWriterOptions& opts,
+ const TabletColumn* column,
io::FileWriter* file_writer,
+ std::unique_ptr<ColumnWriter>*
writer) {
+ // not support empty struct
+ DCHECK(column->get_subtype_count() >= 1);
+ std::vector<std::unique_ptr<ColumnWriter>> sub_column_writers;
+ sub_column_writers.reserve(column->get_subtype_count());
+ for (uint32_t i = 0; i < column->get_subtype_count(); i++) {
+ const TabletColumn& sub_column = column->get_sub_column(i);
+
+ // create sub writer
+ ColumnWriterOptions column_options;
+ column_options.meta = opts.meta->mutable_children_columns(i);
+ column_options.need_zone_map = false;
+ column_options.need_bloom_filter = sub_column.is_bf_column();
+ column_options.need_bitmap_index = sub_column.has_bitmap_index();
+ if (sub_column.type() == FieldType::OLAP_FIELD_TYPE_STRUCT) {
Review Comment:
should be a function, repeated too many time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
