HappenLee commented on code in PR #35883:
URL: https://github.com/apache/doris/pull/35883#discussion_r1628877629
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -3421,10 +3519,12 @@ void DateV2Value<T>::set_microsecond(uint32_t
microsecond) {
}
template <typename T>
-bool DateV2Value<T>::to_format_string(const char* format, int len, char* to)
const {
+bool DateV2Value<T>::to_format_string(const char* format, int len, char* to,
Review Comment:
should simple the function, too much if check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
