zuochunwei commented on a change in pull request #8090:
URL: https://github.com/apache/incubator-doris/pull/8090#discussion_r808677199
##########
File path: be/src/vec/exec/join/vhash_join_node.cpp
##########
@@ -317,10 +319,10 @@ struct ProcessHashTableProbe {
for (auto it = mapped.begin(); it.ok(); ++it) {
++current_offset;
for (size_t j = 0; j < right_col_len; ++j) {
- auto& column = *it->block->get_by_position(j).column;
+ auto& column = *it->block()->get_by_position(j).column;
mcol[j + right_col_idx]->insert_from(column,
it->row_num);
}
- visited_map.emplace_back(&it->visited);
+ visited_map.emplace_back(&(*it));
Review comment:
&(*it) is not same to it, this is because ForwardIterator has overloaded
the operator*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
