github-actions[bot] commented on code in PR #34653:
URL: https://github.com/apache/doris/pull/34653#discussion_r1630716295
##########
be/src/vec/sink/vdata_stream_sender.h:
##########
@@ -275,11 +273,7 @@ class PipChannel final : public
Channel<pipeline::ExchangeSinkLocalState> {
ch_roll_pb_block();
}
- ~PipChannel() override {
- if (Channel<pipeline::ExchangeSinkLocalState>::_ch_cur_pb_block) {
- delete Channel<pipeline::ExchangeSinkLocalState>::_ch_cur_pb_block;
- }
- }
+ ~PipChannel() override { delete
Channel<pipeline::ExchangeSinkLocalState>::_ch_cur_pb_block; }
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```cpp
~PipChannel() override { delete
Channel<pipeline::ExchangeSinkLocalState>::_ch_cur_pb_block; }
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
