liaoxin01 commented on code in PR #36050:
URL: https://github.com/apache/doris/pull/36050#discussion_r1634049385
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalOlapTableSink.java:
##########
@@ -202,9 +202,12 @@ public PhysicalProperties getRequirePhysicalProperties() {
DistributionInfo distributionInfo =
targetTable.getDefaultDistributionInfo();
if (distributionInfo instanceof HashDistributionInfo) {
// Do not enable shuffle for duplicate key tables when its
tablet num is less than threshold.
- if (targetTable.getKeysType() == KeysType.DUP_KEYS
- && distributionInfo.getBucketNum() <
Config.min_tablets_for_dup_table_shuffle) {
- return PhysicalProperties.ANY;
+ if (targetTable.getKeysType() == KeysType.DUP_KEYS) {
+ final long partitionNums =
targetTable.getPartitionInfo().getAllPartitions().size();
Review Comment:
```suggestion
final long partitionNums = partitionIds.size();
```
`partitionIds` are the current partitions to be imported？If that's the
case，using the size of `partitionIds` would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
