JNSimba commented on a change in pull request #4:
URL:
https://github.com/apache/incubator-doris-flink-connector/pull/4#discussion_r809699541
##########
File path:
flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisDynamicTableSink.java
##########
@@ -65,7 +66,7 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
.setExecutionOptions(executionOptions)
.setFieldDataTypes(tableSchema.getFieldDataTypes())
.setFieldNames(tableSchema.getFieldNames());
- return OutputFormatProvider.of(builder.build());
+ return new GenericDorisSinkFunction(builder.build());
Review comment:
I think it maybe better to use `SinkFunctionProvider.of(new
GenericDorisSinkFunction(builder.build()))`.
And there should be has exceptions in the **type conversion** between
`GenericDorisSinkFunction` and `SinkRuntimeProvider`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
