csun5285 commented on code in PR #35459:
URL: https://github.com/apache/doris/pull/35459#discussion_r1634546331
##########
be/src/olap/rowset/segment_v2/inverted_index_fs_directory.cpp:
##########
@@ -341,36 +340,22 @@ DorisFSDirectory::DorisFSDirectory() {
this->lockFactory = nullptr;
}
-void DorisFSDirectory::init(const io::FileSystemSPtr& _fs, const char* _path,
- bool use_compound_file_writer,
lucene::store::LockFactory* lock_factory,
- const io::FileSystemSPtr& cfs, const char*
cfs_path) {
- fs = _fs;
- directory = _path;
- useCompoundFileWriter = use_compound_file_writer;
-
- if (cfs == nullptr) {
- compound_fs = fs;
- } else {
- compound_fs = cfs;
- }
- if (cfs_path != nullptr) {
- cfs_directory = cfs_path;
- } else {
- cfs_directory = _path;
- }
-
+void DorisFSDirectory::init(const io::FileSystemSPtr& fs, const char* path,
+ lucene::store::LockFactory* lock_factory) {
+ _fs = fs;
+ directory = path;
if (lock_factory == nullptr) {
lock_factory = _CLNEW lucene::store::NoLockFactory();
}
lucene::store::Directory::setLockFactory(lock_factory);
// It's fail checking directory existence in S3.
- if (fs->type() == io::FileSystemType::S3) {
+ if (_fs->type() == io::FileSystemType::S3) {
Review Comment:
S3 file system now supports the `exists`
##########
be/src/olap/rowset/segment_v2/inverted_index_fs_directory.cpp:
##########
@@ -82,7 +82,6 @@
namespace doris::segment_v2 {
const char* const DorisFSDirectory::WRITE_LOCK_FILE = "write.lock";
-const char* const DorisFSDirectory::COMPOUND_FILE_EXTENSION = ".idx";
class DorisFSDirectory::FSIndexOutput : public
lucene::store::BufferedIndexOutput {
Review Comment:
`DorisFSDirectory::FSIndexInput` is declared in
`inverted_index_fs_directory.h`, while `DorisFSDirectory::FSIndexOutput` is
declared in `inverted_index_fs_directory.cpp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
