yangzhg commented on a change in pull request #8069:
URL: https://github.com/apache/incubator-doris/pull/8069#discussion_r810443923
##########
File path: be/src/util/arrow/row_batch.cpp
##########
@@ -300,7 +300,7 @@ class FromRowBatchConverter : public arrow::TypeVisitor {
arrow::NumericBuilder<T> builder(_pool);
size_t num_rows = _batch.num_rows();
- builder.Reserve(num_rows);
+ ARROW_RETURN_NOT_OK(builder.Reserve(num_rows));
Review comment:
yes, Reserve is not void function, we do not use the return value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
