dataroaring opened a new pull request #8148:
URL: https://github.com/apache/incubator-doris/pull/8148


   # Proposed changes
   make asan work as much as possible
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   Manually ASAN poisoning is complicated and it is hard to make it work right. 
There are illustrated examples in 
http://blog.hostilefork.com/poison-memory-without-asan/.
   
   Stacks of use after poison do not provide enough information to resolve bug, 
while stacks of use afer free provide. 
https://github.com/google/sanitizers/issues/191
   
   We'd better implement a mempool using malloc/free directly, thus asan works 
natively. However we cannot do it in a short time, so we make manual poisoning 
work as much as possible.
   
   I refers to https://github.com/mcgov/asan_alignment_example.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (No)
   2. Has unit tests been added: (No)
   3. Has document been added or modified: (No)
   4. Does it need to update dependencies: (No)
   5. Are there any changes that cannot be rolled back: (No)
   
   ## Further comments
   
   We need much more work to make asan work, for example we need fix manual 
poison in ./be/src/olap/rowset/segment_v2/bitshuffle_page.h and I am not sure 
if there are any places.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to