github-actions[bot] commented on code in PR #34089:
URL: https://github.com/apache/doris/pull/34089#discussion_r1635954273
##########
be/src/olap/tablet_schema.h:
##########
@@ -23,6 +23,7 @@
#include <gen_cpp/segment_v2.pb.h>
#include <parallel_hashmap/phmap.h>
+#include <algorithm>
Review Comment:
warning: inclusion of deprecated C++ header 'stdint.h'; consider using
'cstdint' instead [modernize-deprecated-headers]
```suggestion
#include <cstdint>
```
##########
be/src/service/point_query_executor.h:
##########
@@ -90,6 +92,14 @@
const vectorized::VExprContextSPtrs& output_exprs() { return
_output_exprs_ctxs; }
+ int32_t rs_column_uid() const { return _row_store_column_ids; }
+
+ const std::unordered_set<int32_t> missing_col_uids() const { return
_missing_col_uids; }
+
+ const std::unordered_set<int32_t> include_col_uids() const { return
_include_col_uids; }
+
Review Comment:
warning: return type 'const int' is 'const'-qualified at the top level,
which may reduce code readability without improving const correctness
[readability-const-return-type]
```suggestion
std::unordered_set<int32_t> include_col_uids() const { return
_include_col_uids; }
```
##########
be/src/service/point_query_executor.h:
##########
@@ -90,6 +92,14 @@ class Reusable {
const vectorized::VExprContextSPtrs& output_exprs() { return
_output_exprs_ctxs; }
+ int32_t rs_column_uid() const { return _row_store_column_ids; }
+
+ const std::unordered_set<int32_t> missing_col_uids() const { return
_missing_col_uids; }
+
Review Comment:
warning: return type 'const int' is 'const'-qualified at the top level,
which may reduce code readability without improving const correctness
[readability-const-return-type]
```suggestion
std::unordered_set<int32_t> missing_col_uids() const { return
_missing_col_uids; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
