morrySnow commented on code in PR #35925:
URL: https://github.com/apache/doris/pull/35925#discussion_r1636045347
##########
regression-test/suites/nereids_tpcds_shape_sf100_p0/noStatsRfPrune/query1.groovy:
##########
@@ -45,7 +45,7 @@ where sr_returned_date_sk = d_date_sk
and d_year =2000
group by sr_customer_sk
,sr_store_sk)
- select c_customer_id
+ select /*+ FORCE_CBO_RULE(no_push_down_agg_through_join
no_push_down_agg_through_join_one_side) */ c_customer_id
Review Comment:
we need force no use to avoid shape changed? i think the shape check should
not add any hint. because it used to check plan shape under all default set
##########
regression-test/suites/nereids_tpcds_shape_sf100_p0/noStatsRfPrune/query1.groovy:
##########
@@ -45,7 +45,7 @@ where sr_returned_date_sk = d_date_sk
and d_year =2000
group by sr_customer_sk
,sr_store_sk)
- select c_customer_id
+ select /*+ FORCE_CBO_RULE(no_push_down_agg_through_join
no_push_down_agg_through_join_one_side) */ c_customer_id
Review Comment:
we should check perfermance is ok after let these rules become cost based
rewrite tule
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1201,9 +1201,6 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag)
{
@VariableMgr.VarAttr(name = DISABLE_NEREIDS_RULES, needForward = true)
private String disableNereidsRules = "";
- @VariableMgr.VarAttr(name = ENABLE_NEREIDS_RULES, needForward = true)
- public String enableNereidsRules = "";
-
Review Comment:
not remove it directly, use varType REMOVED to avoid set failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
