yujun777 commented on code in PR #35970:
URL: https://github.com/apache/doris/pull/35970#discussion_r1636234533
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -1470,6 +1468,67 @@ private void checkReplicaContinuousVersionSucc(long
tabletId, Replica replica, b
}
}
+ private void checkReplicaContinuousVersionSucc(long tabletId, Replica
replica, boolean alterReplicaLoadedTxn,
+ long minReplicaVersion, long maxReplicaVersion,
List<PublishVersionTask> replicaPublishTasks,
+ Set<Long> errorReplicaIds, List<Replica> tabletSuccReplicas,
List<Replica> tabletWriteFailedReplicas,
+ List<Replica> tabletVersionFailedReplicas) {
+ boolean failed = false;
+ for (PublishVersionTask task : replicaPublishTasks) {
+ if (task == null || !task.isFinished()) {
+ errorReplicaIds.add(replica.getId());
+ failed = true;
+ }
+ }
+ if (!failed) {
+ for (PublishVersionTask task : replicaPublishTasks) {
+ Map<Long, Long> backendSuccTablets = task.getSuccTablets();
+ // new doris BE will report succ tablets
+ if (backendSuccTablets != null) {
+ if (!backendSuccTablets.containsKey(tabletId)) {
+ failed = true;
+ break;
+ }
+ } else {
Review Comment:
delete 1491 ~ 1497, because this code is just for compatibility and it's
too old ( < 2.0.3), the new BE should use new code. can delete this
compatibility code then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
