Dragonliu2018 commented on code in PR #36280:
URL: https://github.com/apache/doris/pull/36280#discussion_r1639100590
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DefaultValue.java:
##########
@@ -40,6 +41,8 @@ public class DefaultValue {
public static DefaultValue BITMAP_EMPTY_DEFAULT_VALUE = new
DefaultValue(ZERO);
// default "value", "[]" means empty array
public static DefaultValue ARRAY_EMPTY_DEFAULT_VALUE = new
DefaultValue("[]");
+ // default "value", "3.14159265358979323846" means pi
+ public static DefaultValue PI_DEFAULT_VALUE = new
DefaultValue("3.14159265358979323846", PI);
Review Comment:
Get, i'll add a code comment here.
`M_PI` is enough, because the precision of type double is 15~16 digits. but
it is not adequate for computation using long double. in this case, use `M_PIl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
