zhannngchen commented on code in PR #35856:
URL: https://github.com/apache/doris/pull/35856#discussion_r1639503215
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -546,6 +548,36 @@ Status CloudMetaMgr::sync_tablet_rowsets(CloudTablet*
tablet, bool warmup_delta_
}
}
+bool CloudMetaMgr::sync_tablet_delete_bitmap_by_cache(CloudTablet* tablet,
int64_t old_max_version,
+ std::ranges::range
auto&& rs_metas,
+ DeleteBitmap*
delete_bitmap) {
+ std::set<int64_t> txn_processed;
+ for (auto& rs_meta : rs_metas) {
+ auto txn_id = rs_meta.txn_id();
+ if (txn_processed.find(txn_id) != txn_processed.end()) {
+ continue;
+ }
+ txn_processed.insert(txn_id);
+ DeleteBitmapPtr tmp_delete_bitmap;
+ RowsetIdUnorderedSet tmp_rowset_ids;
+ std::shared_ptr<PublishStatus> publish_status =
+ std::make_shared<PublishStatus>(PublishStatus::INIT);
+ CloudStorageEngine& engine =
ExecEnv::GetInstance()->storage_engine().to_cloud();
+ Status status = engine.txn_delete_bitmap_cache().get_delete_bitmap(
+ txn_id, tablet->tablet_id(), &tmp_delete_bitmap,
&tmp_rowset_ids, &publish_status);
+ if (status.ok() && *(publish_status.get()) == PublishStatus::SUCCEED) {
+ delete_bitmap->merge(*tmp_delete_bitmap);
Review Comment:
you need to call `_remove_sentinel_mark_from_delete_bitmap()` before add the
delete bitmap into the cache, which is removed in #34588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
