gavinchou commented on code in PR #36341:
URL: https://github.com/apache/doris/pull/36341#discussion_r1640922166
##########
be/src/runtime/runtime_state.cpp:
##########
@@ -351,6 +370,16 @@ Status RuntimeState::cancel_reason() const {
const int64_t MAX_ERROR_NUM = 50;
Status RuntimeState::create_error_log_file() {
+ if (config::save_error_log_to_s3) {
+ _s3_error_fs =
ExecEnv::GetInstance()->storage_engine().to_cloud().latest_fs();
Review Comment:
This cast may not work if the config::is_cloud_mode() is not true;
##########
be/src/cloud/config.cpp:
##########
@@ -55,6 +55,8 @@ DEFINE_mInt32(schedule_sync_tablets_interval_s, "600");
DEFINE_mInt32(mow_stream_load_commit_retry_times, "10");
+DEFINE_mBool(save_error_log_to_s3, "false");
Review Comment:
```suggestion
DEFINE_mBool(save_load_error_log_to_s3, "false");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
