zclllyybb commented on PR #36525: URL: https://github.com/apache/doris/pull/36525#issuecomment-2186527513
> > > > Is this feature(show config) supported in Nereids? > > > > > > > > > ShowStmt does not differentiate between old and new optimizers，so it works with both. > > > > > > should what `fe/fe-core/src/main/cup/sql_parser.cup` implements also be implemented in `nereids/DorisParser.g4`? AFAIK, now it can't be parsed by nereids? then when we deprecate legacy planner in near future, should we also imp it in nereids? > > The NereidsParser can't parse all ShowStmt (e.g., `show frontends` stmt) and it will rollback to old SqlParser now, is there a plan to deprecate the old SqlParser and remove `sql_parser.cup` when we deprecate legacy planner in near future? I think so. But if all ShowStmt are not supported now for nereids, it's also good for this pr. The optimizer group may look forward for nereids compatible in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
