This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 20d75efd26b [fix](group commit) Group commit http stream should not
begin txn (#36926)
20d75efd26b is described below
commit 20d75efd26b2d4d51808e59d48475b5361b33bb9
Author: meiyi <[email protected]>
AuthorDate: Thu Jun 27 21:21:07 2024 +0800
[fix](group commit) Group commit http stream should not begin txn (#36926)
## Proposed changes
After nereids support group_commit, the http_stream in group commit will
also do some check like insert into values, and change the group_commit
flag to false.
Then will begin a txn. This is hang schema change.
---
.../trees/plans/commands/insert/GroupCommitInsertExecutor.java | 4 ++++
1 file changed, 4 insertions(+)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/GroupCommitInsertExecutor.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/GroupCommitInsertExecutor.java
index f4d640e2c64..08686561a41 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/GroupCommitInsertExecutor.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/GroupCommitInsertExecutor.java
@@ -81,6 +81,10 @@ public class GroupCommitInsertExecutor extends
AbstractInsertExecutor {
*/
public static boolean canGroupCommit(ConnectContext ctx, DataSink sink,
PhysicalSink physicalSink,
NereidsPlanner planner) {
+ // The flag is set to false before execute sql, if it is true, this is
a http stream
+ if (ctx.isGroupCommit()) {
+ return false;
+ }
PhysicalOlapTableSink<?> olapSink = (PhysicalOlapTableSink<?>)
physicalSink;
boolean can = analyzeGroupCommit(ctx, sink, olapSink, planner);
ctx.setGroupCommit(can);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
