EmmyMiao87 commented on a change in pull request #8202:
URL: https://github.com/apache/incubator-doris/pull/8202#discussion_r817310040
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java
##########
@@ -147,7 +155,9 @@ private ExportJob createJob(long jobId, ExportStmt stmt)
throws Exception {
continue;
}
Review comment:
```suggestion
If ( label not null or empty) {
if (isLabelUseLike) {
check pattern;
} else {
check job label;
}
}
```
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java
##########
@@ -126,11 +129,16 @@ private ExportJob createJob(long jobId, ExportStmt stmt)
throws Exception {
// NOTE: jobid and states may both specified, or only one of them, or
neither
public List<List<String>> getExportJobInfosByIdOrState(
- long dbId, long jobId, String label, Set<ExportJob.JobState>
states,
- ArrayList<OrderByPair> orderByPairs, long limit) {
+ long dbId, long jobId, String label, boolean isLabelUseLike,
Set<ExportJob.JobState> states,
+ ArrayList<OrderByPair> orderByPairs, long limit) throws
AnalysisException {
long resultNum = limit == -1L ? Integer.MAX_VALUE : limit;
LinkedList<List<Comparable>> exportJobInfos = new
LinkedList<List<Comparable>>();
+ PatternMatcher matcher = null;
+ if(isLabelUseLike){
Review comment:
Pay attention about code format ~
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java
##########
@@ -147,7 +155,9 @@ private ExportJob createJob(long jobId, ExportStmt stmt)
throws Exception {
continue;
}
- if (!Strings.isNullOrEmpty(label) && !jobLabel.equals(label)) {
+ if (!Strings.isNullOrEmpty(label) &&
Review comment:
The above way of writing is more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
