github-actions[bot] commented on code in PR #37220:
URL: https://github.com/apache/doris/pull/37220#discussion_r1663881045
##########
be/src/runtime/routine_load/routine_load_task_executor.cpp:
##########
@@ -338,7 +338,7 @@ void
RoutineLoadTaskExecutor::exec_task(std::shared_ptr<StreamLoadContext> ctx,
} while (false);
LOG(INFO) << "begin to execute routine load task: " << ctx->brief();
-
+ HANDLE_ERROR(_early_quit_for_task(ctx), "exec_task early quit");
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```cpp
HANDLE_ERROR(_early_quit_for_task(ctx), "exec_task early quit");
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/routine_load/routine_load_task_executor.cpp:318:** expanded
from macro 'HANDLE_ERROR'
```cpp
if (UNLIKELY(!_status_.ok() && !_status_.is<PUBLISH_TIMEOUT>())) { \
^
```
**be/src/common/compiler_util.h:35:** expanded from macro 'UNLIKELY'
```cpp
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^
```
</details>
##########
be/src/runtime/routine_load/routine_load_task_executor.cpp:
##########
@@ -451,6 +452,7 @@
// So just print a warning
LOG(WARNING) << st;
}
+ HANDLE_ERROR(_early_quit_for_task(ctx), "exec_task early quit");
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```cpp
HANDLE_ERROR(_early_quit_for_task(ctx), "exec_task early quit");
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/routine_load/routine_load_task_executor.cpp:318:** expanded
from macro 'HANDLE_ERROR'
```cpp
if (UNLIKELY(!_status_.ok() && !_status_.is<PUBLISH_TIMEOUT>())) { \
^
```
**be/src/common/compiler_util.h:35:** expanded from macro 'UNLIKELY'
```cpp
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^
```
</details>
##########
be/src/runtime/routine_load/routine_load_task_executor.cpp:
##########
@@ -419,6 +419,7 @@
ctx->load_cost_millis = UnixMillis() - ctx->start_millis;
+ HANDLE_ERROR(_early_quit_for_task(ctx), "exec_task early quit");
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```cpp
HANDLE_ERROR(_early_quit_for_task(ctx), "exec_task early quit");
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/routine_load/routine_load_task_executor.cpp:318:** expanded
from macro 'HANDLE_ERROR'
```cpp
if (UNLIKELY(!_status_.ok() && !_status_.is<PUBLISH_TIMEOUT>())) { \
^
```
**be/src/common/compiler_util.h:35:** expanded from macro 'UNLIKELY'
```cpp
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
