yujun777 commented on code in PR #37170: URL: https://github.com/apache/doris/pull/37170#discussion_r1663893565
########## be/src/common/config.cpp: ########## @@ -322,7 +322,7 @@ DEFINE_mInt32(garbage_sweep_batch_size, "100"); DEFINE_mInt32(snapshot_expire_time_sec, "172800"); // It is only a recommended value. When the disk space is insufficient, // the file storage period under trash dose not have to comply with this parameter. -DEFINE_mInt32(trash_file_expire_time_sec, "259200"); +DEFINE_mInt32(trash_file_expire_time_sec, "86400"); Review Comment: trash 很费，实际中没用，trash 的副本在fe中元数据都是必定不存在的，即使手工把它从trash 中拉回来，在fe 元数据也不含它， 把它搞回来后， 都还不能用。 真正的回收站是 fe catalog recycle bin， 这部分的数据在BE中是一直在data目录中的，跟trash没关系， 可以通过recover 命令把 fe recycle bin 中的数据给恢复过来。 线上给用户建议时，都是直接建议直接把这个值设置为0的。 后续再提个pr把它清了吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
