morningman commented on a change in pull request #8123:
URL: https://github.com/apache/incubator-doris/pull/8123#discussion_r817370825
##########
File path: fe/fe-core/src/main/java/org/apache/doris/clone/TabletScheduler.java
##########
@@ -1023,17 +1042,15 @@ private boolean handleReplicaTooSlow(TabletSchedCtx
tabletCtx) throws SchedExcep
}
}
- if (chosenReplica != null && !chosenReplica.equals(minReplica) &&
minReplica.isAlive()) {
- try {
-
Catalog.getCurrentCatalog().setReplicaStatus(tabletCtx.getTabletId(),
chosenReplica.getBackendId(),
- Replica.ReplicaStatus.BAD);
- throw new SchedException(Status.FINISHED, "set slow replica as
bad");
- } catch (MetaNotFoundException e) {
- LOG.warn("set slow replica bad failed:", e);
- return false;
- }
+ if (chosenReplica != null && !chosenReplica.equals(minReplica) &&
minReplica.isAlive()
+ && aliveReplicaCount >= (replicaCount / 2 + 1)) {
Review comment:
If there the replica num is 2, then we can not handle this situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
