github-actions[bot] commented on code in PR #37253:
URL: https://github.com/apache/doris/pull/37253#discussion_r1664437653
##########
be/src/vec/data_types/serde/data_type_map_serde.cpp:
##########
@@ -397,7 +397,8 @@ void DataTypeMapSerDe::read_column_from_arrow(IColumn&
column, const arrow::Arra
template <bool is_binary_format>
Status DataTypeMapSerDe::_write_column_to_mysql(const IColumn& column,
Review Comment:
warning: function '_write_column_to_mysql' has cognitive complexity of 84
(threshold 50) [readability-function-cognitive-complexity]
```cpp
Status DataTypeMapSerDe::_write_column_to_mysql(const IColumn& column,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/data_types/serde/data_type_map_serde.cpp:409:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (0 != result.push_string("{", 1)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:413:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (auto j = offsets[col_index - 1]; j < offsets[col_index]; ++j) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:414:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (j != offsets[col_index - 1]) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:415:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
if (0 != result.push_string(", ", 2)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:419:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (nested_keys_column.is_null_at(j)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:420:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
if (0 != result.push_string(options.null_format,
options.null_len)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:423:** +1, nesting
level increased to 2
```cpp
} else {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:424:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
if (is_key_string && options.wrapper_len > 0) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:424:** +1
```cpp
if (is_key_string && options.wrapper_len > 0) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:425:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
if (0 != result.push_string(options.nested_string_wrapper,
options.wrapper_len)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:428:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(key_serde->write_column_to_mysql(nested_keys_column, result, j,
^
```
**be/src/common/status.h:612:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:428:** +5, including
nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(key_serde->write_column_to_mysql(nested_keys_column, result, j,
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:430:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
if (0 != result.push_string(options.nested_string_wrapper,
options.wrapper_len)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:433:** +1, nesting
level increased to 3
```cpp
} else {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:434:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(key_serde->write_column_to_mysql(nested_keys_column, result, j,
^
```
**be/src/common/status.h:612:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:434:** +5, including
nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(key_serde->write_column_to_mysql(nested_keys_column, result, j,
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:438:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (0 != result.push_string(&options.map_key_delim, 1)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:441:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (nested_values_column.is_null_at(j)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:442:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
if (0 != result.push_string(options.null_format,
options.null_len)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:445:** +1, nesting
level increased to 2
```cpp
} else {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:446:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
if (is_val_string && options.wrapper_len > 0) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:446:** +1
```cpp
if (is_val_string && options.wrapper_len > 0) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:447:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
if (0 != result.push_string(options.nested_string_wrapper,
options.wrapper_len)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:450:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(value_serde->write_column_to_mysql(nested_values_column,
result, j,
^
```
**be/src/common/status.h:612:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:450:** +5, including
nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(value_serde->write_column_to_mysql(nested_values_column,
result, j,
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:452:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
if (0 != result.push_string(options.nested_string_wrapper,
options.wrapper_len)) {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:455:** +1, nesting
level increased to 3
```cpp
} else {
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:456:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(value_serde->write_column_to_mysql(nested_values_column,
result, j,
^
```
**be/src/common/status.h:612:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:456:** +5, including
nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(value_serde->write_column_to_mysql(nested_values_column,
result, j,
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/data_types/serde/data_type_map_serde.cpp:461:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (0 != result.push_string("}", 1)) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
