caiconghui commented on a change in pull request #8146:
URL: https://github.com/apache/incubator-doris/pull/8146#discussion_r818264486



##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -616,19 +615,12 @@ bool TabletManager::get_rowset_id_from_path(const string& 
path, RowsetId* rowset
 }
 
 void TabletManager::get_tablet_stat(TTabletStatResult* result) {
-    int64_t curr_ms = UnixMillis();
-    // Update cache if it is too old
+    std::shared_ptr<std::vector<TTabletStat>> local_cache;

Review comment:
       it is Inefficient,we can produce cache in build_tablet_info function 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to