github-actions[bot] commented on code in PR #37287:
URL: https://github.com/apache/doris/pull/37287#discussion_r1665312253
##########
cloud/src/meta-service/meta_service_job.cpp:
##########
@@ -499,14 +500,15 @@
txn->put(lock_key, lock_val);
}
-void process_compaction_job(MetaServiceCode& code, std::string& msg,
std::stringstream& ss,
- std::unique_ptr<Transaction>& txn,
+void process_compaction_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
Review Comment:
warning: function 'process_compaction_job' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
void process_compaction_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
^
```
<details>
<summary>Additional context</summary>
**cloud/src/meta-service/meta_service_job.cpp:502:** 349 lines including
whitespace and comments (threshold 80)
```cpp
void process_compaction_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
^
```
</details>
##########
cloud/src/meta-service/meta_service_job.cpp:
##########
@@ -49,10 +47,10 @@ namespace doris::cloud {
static constexpr int COMPACTION_DELETE_BITMAP_LOCK_ID = -1;
static constexpr int SCHEMA_CHANGE_DELETE_BITMAP_LOCK_ID = -2;
-void start_compaction_job(MetaServiceCode& code, std::string& msg,
std::stringstream& ss,
- std::unique_ptr<Transaction>& txn, const
StartTabletJobRequest* request,
- StartTabletJobResponse* response, std::string&
instance_id,
- bool& need_commit) {
+void start_compaction_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
Review Comment:
warning: function 'start_compaction_job' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
void start_compaction_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
^
```
<details>
<summary>Additional context</summary>
**cloud/src/meta-service/meta_service_job.cpp:49:** 159 lines including
whitespace and comments (threshold 80)
```cpp
void start_compaction_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
^
```
</details>
##########
cloud/src/meta-service/meta_service_job.cpp:
##########
@@ -853,14 +855,15 @@
need_commit = true;
}
-void process_schema_change_job(MetaServiceCode& code, std::string& msg,
std::stringstream& ss,
- std::unique_ptr<Transaction>& txn,
+void process_schema_change_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
Review Comment:
warning: function 'process_schema_change_job' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
void process_schema_change_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
^
```
<details>
<summary>Additional context</summary>
**cloud/src/meta-service/meta_service_job.cpp:857:** 269 lines including
whitespace and comments (threshold 80)
```cpp
void process_schema_change_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
^
```
</details>
##########
cloud/src/meta-service/meta_service_job.cpp:
##########
@@ -499,14 +500,15 @@
txn->put(lock_key, lock_val);
}
-void process_compaction_job(MetaServiceCode& code, std::string& msg,
std::stringstream& ss,
- std::unique_ptr<Transaction>& txn,
+void process_compaction_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
Review Comment:
warning: function 'process_compaction_job' has cognitive complexity of 52
(threshold 50) [readability-function-cognitive-complexity]
```cpp
void process_compaction_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
^
```
<details>
<summary>Additional context</summary>
**cloud/src/meta-service/meta_service_job.cpp:515:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (recorded_job.compaction().empty()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:525:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
for (; recorded_compaction != recorded_job.mutable_compaction()->end();
++recorded_compaction) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:526:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (recorded_compaction->id() == compaction.id()) break;
^
```
**cloud/src/meta-service/meta_service_job.cpp:528:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (recorded_compaction == recorded_job.mutable_compaction()->end()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:538:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (recorded_compaction->expiration() > 0 &&
recorded_compaction->expiration() < now) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:538:** +1
```cpp
if (recorded_compaction->expiration() > 0 &&
recorded_compaction->expiration() < now) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:548:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (request->action() != FinishTabletJobRequest::COMMIT &&
^
```
**cloud/src/meta-service/meta_service_job.cpp:560:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (request->action() == FinishTabletJobRequest::LEASE) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:561:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (compaction.lease() <= 0 || recorded_compaction->lease() >
compaction.lease()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:561:** +1
```cpp
if (compaction.lease() <= 0 || recorded_compaction->lease() >
compaction.lease()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:580:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (request->action() == FinishTabletJobRequest::ABORT) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:587:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (compaction.has_delete_bitmap_lock_initiator()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:615:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (compaction.type() == TabletCompactionJobPB::EMPTY_CUMULATIVE) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:619:** +1, nesting level
increased to 1
```cpp
} else if (compaction.type() == TabletCompactionJobPB::CUMULATIVE) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:622:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (compaction.output_cumulative_point() >
stats->cumulative_point()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:633:** +1, nesting level
increased to 1
```cpp
} else if (compaction.type() == TabletCompactionJobPB::BASE) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:642:** +1, nesting level
increased to 1
```cpp
} else if (compaction.type() == TabletCompactionJobPB::FULL) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:645:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (compaction.output_cumulative_point() >
stats->cumulative_point()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:656:** +1, nesting level
increased to 1
```cpp
} else {
^
```
**cloud/src/meta-service/meta_service_job.cpp:665:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (stats->data_size() < 0 || stats->num_rowsets() < 1) [[unlikely]] {
^
```
**cloud/src/meta-service/meta_service_job.cpp:665:** +1
```cpp
if (stats->data_size() < 0 || stats->num_rowsets() < 1) [[unlikely]] {
^
```
**cloud/src/meta-service/meta_service_job.cpp:677:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (compaction.type() == TabletCompactionJobPB::EMPTY_CUMULATIVE) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:688:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (compaction.has_delete_bitmap_lock_initiator()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:692:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!success) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:700:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (compaction.input_versions_size() != 2 ||
compaction.output_versions_size() != 1 ||
^
```
**cloud/src/meta-service/meta_service_job.cpp:700:** +1
```cpp
if (compaction.input_versions_size() != 2 ||
compaction.output_versions_size() != 1 ||
^
```
**cloud/src/meta-service/meta_service_job.cpp:725:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
do {
^
```
**cloud/src/meta-service/meta_service_job.cpp:727:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (err != TxnErrorCode::TXN_OK) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:736:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
while (it->has_next()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:740:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (!rs.ParseFromArray(v.data(), v.size())) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:749:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (compaction.has_delete_bitmap_lock_initiator()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:768:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (!it->has_next()) rs_start1 = k;
^
```
**cloud/src/meta-service/meta_service_job.cpp:777:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (num_rowsets < 1) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:794:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (compaction.txn_id_size() != 1) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:802:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (txn_id <= 0 || rowset_id.empty()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:802:** +1
```cpp
if (txn_id <= 0 || rowset_id.empty()) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:812:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (err != TxnErrorCode::TXN_OK) {
^
```
**cloud/src/meta-service/meta_service_job.cpp:826:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (rs_meta.txn_id() <= 0) {
^
```
</details>
##########
cloud/src/meta-service/meta_service_job.cpp:
##########
@@ -212,10 +210,10 @@
need_commit = true;
}
-void start_schema_change_job(MetaServiceCode& code, std::string& msg,
std::stringstream& ss,
- std::unique_ptr<Transaction>& txn,
- const StartTabletJobRequest* request,
std::string& instance_id,
+void start_schema_change_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
Review Comment:
warning: function 'start_schema_change_job' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
void start_schema_change_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
^
```
<details>
<summary>Additional context</summary>
**cloud/src/meta-service/meta_service_job.cpp:212:** 96 lines including
whitespace and comments (threshold 80)
```cpp
void start_schema_change_job(MetaServiceCode& code, std::string& msg,
Transaction* txn,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
